Address PR #5 review: tighten validator and template#6
Merged
Conversation
Addresses the 5 minor issues from the code review:
- no-external-deps: detect dynamic import() via lookbehind; scope ESM
import/export to <script> blocks. Lookbehind fixes a line-number
off-by-one when the prefix newline was being captured.
- no-hardcoded-hex: mask url(...) contents and quoted strings before
scanning, so URL fragments like icon-3f4a2b.png or #abc123 no longer
false-positive as colors.
- security-hardening: rewrite the innerHTML check to capture the RHS
and inspect it programmatically. Now correctly:
- passes static string literals ("..." or '...')
- passes backtick templates without interpolation
- flags template literals containing ${ ... }
- flags bare variable assignments
Error message distinguishes "template literal with interpolation"
from "non-literal expression".
- tests: add explicit "zero issues" assertion for valid.html; add
new valid-with-urls.html fixture covering hex-like strings inside
url() / quotes; extend security fixture with template-literal cases.
- status-report-v2.html: replace orphan <a href="#pr-NNNN"> anchors
with <span class="pr-link"> — same styling, no broken links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 5 minor issues from the code review: