feat(TGWUI): replace 'useCondition' with 'condition' in configuration (SP-6679) #116
Conversation
WalkthroughThe configuration files were updated to rename the key "useCondition" to "condition" throughout. Additionally, a conditional default value was added for the "send_pictures" extension to enable it only when the model's pipeline type is "Image-Text-to-Text". No other structural or logic changes were made. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Configuration
participant Model
User->>Configuration: Load configuration.json
Configuration->>Model: Check pipelineType for send_pictures default
Model-->>Configuration: Return pipelineType value
Configuration-->>User: Provide options with "condition" logic applied
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
Text Generation WebUI/configuration.json (2)
1014-1020: Potential dead condition – references a field that exists only for a different loader.
engine.model_loader.transformers_options2.load-in-4bitis used inside the ExLlamav2 branch.
When the loader is ExLlamav2, theTransformersoption block (and thereforetransformers_options2) is not active, so this variable may be undefined and the condition will always evaluate to false.Confirm whether the intent was to link to an ExLlamav2-specific toggle instead.
1-1434: LegacyuseConditionkeys detected – please replace withcondition.Stale
useConditionentries remain in the ComfyUI configs. Update them as follows:• ComfyUI/configuration-gpu.json (line 257)
• ComfyUI/configuration-cpu.json (line 259)Suggested diff for each location:
- "useCondition": { + "condition": {
🧹 Nitpick comments (1)
Text Generation WebUI/configuration.json (1)
171-177: Check interpolation style forcondition.variable.
"variable": "{{global.model.configuration.task.pipelineType}}"uses a double-brace template, whereas every othercondition.variablein this file relies on plain dot-notation.
Unless the runtime explicitly expects handlebars here, keep the style consistent to avoid the expression being treated as a literal string.- "variable": "{{global.model.configuration.task.pipelineType}}", + "variable": "global.model.configuration.task.pipelineType",Also verify that a hard-coded
"boolValue": truecombined with a condition does not lead to ambiguous defaults in the consumer code.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Text Generation WebUI/configuration.json(29 hunks)
🔇 Additional comments (8)
Text Generation WebUI/configuration.json (8)
433-438: LGTM – conditional blocks for the Transformers loader look correct.The dot-notation paths resolve cleanly and guard the UI sections as intended.
Also applies to: 566-571
491-497: Hyphenated keys can break dot-notation look-ups.Paths such as
engine.model_loader.transformers_options2.load-in-4bit
contain a hyphenated segment (load-in-4bit). Many JSON-schema interpreters treat the hyphen as a subtraction operator or require bracket notation.If the underlying engine does not support dotted access to hyphenated identifiers, rewrite the paths:
- "variable": "engine.model_loader.transformers_options2.load-in-4bit" + "variable": "engine.model_loader.transformers_options2['load-in-4bit']"Double-check this for every occurrence in the group.
Also applies to: 516-522, 534-540
666-670: LGTM – regex conditions for^llama.*are concise and self-contained.Also applies to: 738-742, 798-802, 828-832, 856-861, 900-904, 930-934
960-965: LGTM – scoped correctly tollamacpp_HF.
1124-1129: LGTM – condition forExLlamav2_HFis precise.
1156-1161: LGTM – AutoGPTQ conditional sections are consistent.Also applies to: 1230-1235, 1274-1279, 1306-1311, 1332-1337
1368-1374: LGTM – HQQ block guarded correctly.
1422-1427: LGTM – conditional tunnel option matches the selected provision type.
…model.task.pipelineType (SP-6679)
Summary by CodeRabbit
New Features
Refactor