Wire CLI to core: teach/do/pack/doctor call real engine functions#8
Closed
SuperInstance wants to merge 1 commit into
Closed
Wire CLI to core: teach/do/pack/doctor call real engine functions#8SuperInstance wants to merge 1 commit into
SuperInstance wants to merge 1 commit into
Conversation
…her-core functions
Changes:
- Teach: changed from stub to Commands::Teach{intent, action},
calls ReflexEngine::teach() to persist reflex to database
- Do: calls ReflexEngine::do_command() which runs exact/similar/novel
intent matching against stored reflexes
- Pack: calls pack_nail() to create real .nail (tar.zst) archives
with BLAKE3 checksums, identity, config, and manifest
- Doctor: checks real conditions — SQLite connectivity, embedder
status, bwrap availability, disk space, hardware fingerprint,
and binary integrity
- Status: wired to ReflexEngine::get_status() for live engine state
- ShellInfo: calls fingerprint() for real hardware fingerprinting
- Reflexes: lists all stored reflexes from the database via schema
- Teach enum variant now takes positional intent and action arguments
- Added expand_tilde() to handle ~ in database paths
Owner
Author
|
Superseded by PR #6 which wires all 13 commands. Keeping the wiring pattern for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the four target stub commands (
teach,do,pack,doctor) inpincher-clito realpincher-corefunctions. Also wiresstatus,shellinfo, andreflexeswhile at it.Changes
pincher teachCommands::Teach { intent: String, action: String }ReflexEngine::teach(&intent, &action)?— persists the reflex to SQLite with embeddings[TAUGHT] reflex <id> — intent: "...", action: "..."pincher doReflexEngine::do_command(&input)?— matches intent against stored reflexespincher packpincher_core::migration::pack_nail(&db_path, &output)?— creates real.nail(tar.zst) archivespincher doctorAlso wired
status: callsReflexEngine::get_status()for live countsshellinfo: callsfingerprint()for real hardware fingerprintingreflexes: lists all reflexes from the database viaget_all_reflexes()expand_tilde()for~/.pincher/...db path supportVerification
cargo test -p pincher-core: 130 tests passpincher teachsuccessfully stores reflexespincher domatches and executes stored reflexespincher packcreates valid zstd-compressed.nailarchivespincher doctorruns 6 real health checkscargo check -p pincher-cli: clean, no warnings