Slim uninstaller copies and enable stub compression #118
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var payloadStart = PayloadExtractor.GetAppendedPayloadStart(installerPath); | ||
| if (payloadStart.HasValue) | ||
| { | ||
| CopyWithoutPayload(installerPath, uninstallerPath, payloadStart.Value); | ||
| Log.Information("Uninstaller written without embedded payload at {Path}", uninstallerPath); |
There was a problem hiding this comment.
The new slim-copy logic truncates the installer at the appended payload (CreateSlimCopy strips everything past the payload start), but the uninstall flow still relies on payload metadata being available alongside the uninstaller. Installer.RegisterUninstaller writes metadata.json only to the installation root, and MetadataFilePayload.FromProcessDirectory looks for it next to Uninstall.exe; without the embedded payload either, DefaultInstallerPayload cannot supply metadata, so UninstallWelcomeViewModel never becomes valid and the wizard cannot proceed when the user launches the registered uninstaller. Please either keep the payload for the uninstall binary or also place the metadata where the slim copy runs.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task