Skip to content

Fix DMG bundle layout for generated apps #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperJMN merged 1 commit into from
Nov 20, 2025
Merged

Fix DMG bundle layout for generated apps #120

SuperJMN merged 1 commit into from
Nov 20, 2025

Conversation

@SuperJMN
Copy link
Owner

@SuperJMN SuperJMN commented Nov 20, 2025

Summary

  • ensure generated DMGs always create a complete .app bundle with Resources and payload under Contents/MacOS
  • include optional .icns icons inside the bundle and advertise them in the Info.plist
  • expand DMG tests to validate sanitized bundle paths and absence of loose payload files

Testing

  • DOTNET_ROLL_FORWARD=LatestMajor dotnet test test/DotnetPackaging.Dmg.Tests/DotnetPackaging.Dmg.Tests.csproj

Codex Task

@SuperJMN SuperJMN merged commit 887a2d7 into master Nov 20, 2025
1 check passed
@SuperJMN SuperJMN deleted the codex/fix-dmg-packaging-error-for-angoravalonia branch November 20, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperJMN