Added an Event logger panel #401
Conversation
# Conflicts: # src/components/projecteditor/ProjectEditor.tsx
|
|
||
| { this.isPanelOpen(Panels.Transactions) && | ||
| <Panel icon={ <IconTransactions /> } name='Transactions History' onClose={() => closePanel(Panels.Transactions)} dragging={sidePanelDragging}> | ||
| <Panel name='Transactions History' onClose={() => closePanel(Panels.Transactions)} dragging={sidePanelDragging}> |
There was a problem hiding this comment.
Question here - is it as intended to remove icons from panels?
There was a problem hiding this comment.
Yeap, it is intended.
There was a problem hiding this comment.
Added it to the PR description
| border-color: transparent; | ||
| padding: 5px; | ||
| transition: all .15s ease; | ||
| border-radius: 0px; |
There was a problem hiding this comment.
Is this one intended? Buttons in panels now have border-radius again after removing this style
There was a problem hiding this comment.
Actually not! Let me remove that one
There was a problem hiding this comment.
I will remove it from the btnNoBg global style instead.
| user-select: none; | ||
| display: block; | ||
| color: #fff; | ||
| line-height: 28px; |
There was a problem hiding this comment.
Explorer feels too much compact on non-retina display. I would consider to have line-height at least 24-25px.
There was a problem hiding this comment.
Sure. In fact, I was just trying to see sort of emulate how VS Code line-height was. Let me check with 24
There was a problem hiding this comment.
Probably not an issue because of this PR, but when you try to deploy contract on a browser which doesn't have Metamask installed you get this error:
Variable row is containing this
We are probably using some functions from web3 which are not injected without Metamask.
|
@Spejbl the previous deployer version contained a runtime check-and-swap action that would choose between the internal web3 object and the externally provided one. Now, when the account is set to
|
|
Thanks @Spejbl for raising that flag but as you said, in fact, I haven't changed that in this PR. Let's add a new issue to the TODO list to make sure this is covered (this will be impacted by @ostap1010 work anyway), but we can set it up as self-reminder to make sure it works as expected. |
# Conflicts: # src/components/app/App.tsx # src/components/app/index.ts # src/components/projecteditor/ProjectEditor.tsx # src/components/projecteditor/style.less # src/models/index.ts # src/reducers/index.ts
4 participants
Description of the Change
Event Logpanel. In order to put messages into the panel, you simply need to call the eventLog.actions/addEventLogRow with a LogLevel and a message and will render in the panel.Benefits
Now we have a panel in which we can display messages to the user related to things the IDE is doing or whatever we consider relevant adding to it (per example when/if introducing plugins)
Verification Process