[pull] main from bytebase:main#162
Merged
pull[bot] merged 2 commits intoSuperoldman96:mainfrom Oct 5, 2025
Merged
Conversation
Replace frontend's manual approval status computation with backend's Issue_ApprovalStatus field. This eliminates duplicated logic and establishes a single source of truth for approval state. Changes: - Update ReviewContext to use Issue_ApprovalStatus instead of Issue_Approver_Status - Remove convertApprovalStatusToApproverStatus helper functions - Simplify extractReviewContext and provideIssueReviewContext to return issue.approvalStatus directly - Update all callers to use Issue_ApprovalStatus constants - Include SKIPPED status in "done" check (approval not required) - Remove unused _reviewStatus parameter from getApplicableIssueStatusActionList Impact: - Reduces code by ~65 lines across 8 files - Eliminates complex approval status computation logic - All approval decisions now rely on backend's computeApprovalStatus() 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
…17647) Backend changes: - Simplify computeApprovalStatus to only return status (not error message) - Use nil-safe Get methods for all approval field access - Remove unnecessary nil checks by relying on protobuf Get methods - Cache approval object to avoid repeated GetApproval() calls - Short-circuit REJECTED status check for better performance - Remove redundant struct field initializations - Ensure backend never returns APPROVAL_STATUS_UNSPECIFIED Frontend changes: - Simplify ReviewContext to only include flow field - Remove unnecessary extractReviewContext calls - Rename approval status variables for clarity: - done/isApproved/approvalDone → rolloutReady - ready → approvalFlowReady - Compute approval status locally instead of from context - Remove APPROVAL_STATUS_UNSPECIFIED checks (backend never returns it) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )