supervisorctl pid <proc> returns exit status 0 for crashed process

[jippi]

Hi

Running latest dev-master (git+https://github.com/Supervisor/supervisor.git@625da4d07cce1a38f1f76905191f54cfe56a945f) running supervisorctl pid users_php-fpm_0 for a process that has crashed return 0 and exit code 0

Running the pid command for something non-crashed returns correct PID

Running the pid command for something non-existing yields a proper error and exit code

[mnaberez]

That all sounds fine. What do you think it should do?

[jippi]

I would have expected output to stderr and exit code != 0 :)

What I did was kill -HUP $(supervisorctl pid <prod>) and expected it to work or abort if the proc was not running or non-existent

[mnaberez]

I would have expected output to stderr and exit code != 0 :)

You want a non-zero exit status from supervisorctl pid <name> if supervisord recognizes the process name but the process has no pid (no process is running). That sounds reasonable to me.

What I did was kill -HUP $(supervisorctl pid ) and expected it to work or abort if the proc was not running or non-existent

You can also use the signal command since Supervisor 3.2.0.

cc @lukeweber

[jippi]

Thanks @mnaberez :)

Basically what I'm doing is signal process or start it it its not running which is simple if the exit codes are present :)