identifier set in command line overwritten by default value #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the identifier may have been set in the command line and not in the configuration file. the last line of ServerOptions.realize systematically overwrites the self.identifier by the value from the configuration file (may be the default one). if the identifier was set in the configuration file, the self.identifier was already updated. so there's no point keeping this instruction.
mnaberez
added a commit
that referenced
this pull request
Dec 28, 2021
dat-h-ammann
pushed a commit
to dat-h-ammann/supervisor
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Supervisor identifier may have been set in the command line and not in the configuration file.
the last line of ServerOptions.realize systematically overwrites the self.identifier by the value from the configuration file (that may be the default one 'supervisor').
if the identifier was set in the configuration file, the self.identifier was already updated.
so there's no point keeping this line.