Separate log targets for syslog (and other streams) #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expect it's not part of the published API.
…just delegate to loggers.getLogger. Added a comment to clarify the purpose.
--HG-- extra : source : 8b4f022c867ea214784b5aa5edb244ddb809ffe5
--HG-- extra : source : 93dba8a25ba4157b1411d6afbe8fbd0f2b1c10e1
--HG-- extra : source : 4eb7b1bd8d707cc2643fdd35f4e0f794c142fc72
…ry to similarly monkey patch the logger here. --HG-- extra : source : 0d23297286a2685c008e87aacfc690d857a0b68d
--HG-- extra : source : b622386559fba4a8ef90a4451e8d578cdcf2854c
…gers. --HG-- extra : source : 8877155f89b3622e3db291b228b379a6c4e12643
--HG-- extra : source : 32505953b7d706d202284fa41d1398a92e1f29b9
Member
|
Thanks for this excellent pull request. I have added it to 3.0b3 milestone and will review it for that release. |
mnaberez
added a commit
that referenced
this pull request
Aug 28, 2013
Separate log targets for syslog (and other streams)
mnaberez
added a commit
that referenced
this pull request
May 20, 2014
The syslog changes introduced in this merge are being reverted on the Supervisor 3.x branch only. These changes remain in the 4.x branch. There are a number of open issues related to syslog support now, and more work may need to be done here. We've decided not to release this in 3.x, but we do intend to include it in Supervisor 4. This reverts commit 2ab5364, reversing changes made to 4d4f9c9. Conflicts: docs/configuration.rst supervisor/tests/test_dispatchers.py
Contributor
Author
When I mentioned that, I meant the patch proposed in #162. |
Contributor
Author
|
@mnaberez Can you tag this issue with syslog? |
mnaberez
added a commit
that referenced
this pull request
Sep 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last pull request added syslog support by adapting a patch supplied by a user to allow specifying 'syslog' as a special "filename" for the log targets. If specified, the setting would then direct the stream for that channel (stdout or stderr) to syslog.
Unfortunately, by invoking this functionality, Supervisord no longer can log to a file nor can it provide a copy of the log in the API, the latter of which was very important for our application.
This new patch, a series of changes that I worked over time and which we're now running in our production environment, allows the user to additionally configure two new settings, 'syslog_stdout' and 'syslog_stderr'. If either are indicated and True, that channel will be directed to syslog, independent of the setting for the file stream.
This change required substantial refactoring to implement as an additional, optional, stream, and I have taken care to describe those changes in deliberately small steps for easier review. All of the changes in this pull request were made as a bare minimum approach to achieve the stated goal in a robust way and no more.
Again, with tests passing and with this running in our production environment, I have confidence that it is a solid improvement. I hope you find the same. Please consider it for inclusion upstream.