Skip to content

Conversation

@msabramo
Copy link
Contributor

by modifying 3 tests to set instance.std{out,err}_logfile to a filename in the temp directory by using tempfile.mktemp

This is an alternative solution to the issue mentioned in #382 and #377.

Before:

$ /bin/rm std*_logfile
$ ls -l std*_logfile
zsh: no matches found: std*_logfile
$ tox -e py26
...
$ ls -l std*_logfile
-rw-r--r--  1 marca  staff     0B Apr 14 08:29 stderr_logfile
-rw-r--r--  1 marca  staff     0B Apr 14 08:29 stdout_logfile

After:

$ /bin/rm std*_logfile
$ ls -l std*_logfile
zsh: no matches found: std*_logfile
$ tox -e py26
...
$ ls -l std*_logfile
zsh: no matches found: std*_logfile

Cc: @mnaberez, @mcdonc, @gcarothers, @graffic

by modifying 3 tests to set instance.std{out,err}_logfile to a filename
in the temp directory by using tempfile.mktemp

This is an alternative solution to the issue mentioned in Supervisor#382 and Supervisor#377.
msabramo added a commit to msabramo/supervisor that referenced this pull request Apr 15, 2014
by modifying 3 tests to use instance.std{out,err}_logfile which are temp
files.

This is an alternative solution to the issue mentioned in Supervisor#382, Supervisor#377,
and Supervisor#417.
msabramo added a commit to msabramo/supervisor that referenced this pull request Apr 15, 2014
by modifying 3 tests to use instance.std{out,err}_logfile which are temp
files.

This is an alternative solution to the issue mentioned in Supervisor#382, Supervisor#377,
and Supervisor#417.

Conflicts:
	supervisor/tests/test_options.py
msabramo added a commit to msabramo/supervisor that referenced this pull request Apr 15, 2014
by modifying 3 tests to use instance.std{out,err}_logfile which are temp
files.

This is an alternative solution to the issue mentioned in Supervisor#382, Supervisor#377,
and Supervisor#417.

Conflicts:
	supervisor/tests/test_options.py
@msabramo
Copy link
Contributor Author

I think that #418 is better because it takes care to delete the temp files.

I'll close this...

@msabramo msabramo closed this Apr 16, 2014
msabramo added a commit to msabramo/supervisor that referenced this pull request Apr 16, 2014
by modifying 3 tests to use instance.std{out,err}_logfile which are temp
files.

This is an alternative solution to the issue mentioned in Supervisor#382, Supervisor#377,
and Supervisor#417.

Conflicts:
	supervisor/tests/test_options.py
msabramo added a commit to msabramo/supervisor that referenced this pull request Apr 16, 2014
by modifying 3 tests to use instance.std{out,err}_logfile which are temp
files.

This is an alternative solution to the issue mentioned in Supervisor#382, Supervisor#377,
and Supervisor#417.

Conflicts:
	supervisor/tests/test_options.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant