Move JudgmentKit install to loopback HTTP#1
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikeylong
force-pushed
the
codex/loopback-http-frontend-skill
branch
from
17b89bf to
1e9b3aa
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17b89bfdd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const body = Buffer.from(await response.arrayBuffer()); | ||
| res.end(body); |
There was a problem hiding this comment.
sendResponse buffers every Response with await response.arrayBuffer() before writing to Node's socket, which breaks long-lived text/event-stream responses returned by handleMcpHttpRequest for Streamable HTTP/SSE clients. In that path the body is intentionally streaming, so waiting for full completion can stall the handshake indefinitely and make the local loopback server unusable for clients that negotiate SSE.
Useful? React with 👍 / 👎.
| endpoint: createLocalMcpUrl(host, port), | ||
| startCommand: materializeLocalPath( | ||
| connection.loopback_runtime.start_command, | ||
| contract, | ||
| checkoutPath, |
There was a problem hiding this comment.
The installer now supports custom --host/--port and writes the MCP endpoint accordingly, but startCommand is still materialized from the static runtime command without embedding those overrides. If a user installs with a non-default port (for example --port 18765) and then runs the printed Start local MCP command, the server starts on defaults (127.0.0.1:8765), so the configured client endpoint and running server no longer match.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation