chore: add FIREFOX_EXTENSION_ID to extension workflow environment variables#397
Merged
SuperCoolPencil merged 1 commit intomainfrom Apr 20, 2026
Merged
chore: add FIREFOX_EXTENSION_ID to extension workflow environment variables#397SuperCoolPencil merged 1 commit intomainfrom
SuperCoolPencil merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Adds
FIREFOX_EXTENSION_ID: surge@surge-downloader.comto theSubmit to AMOstep's environment variables in the extension workflow. Firefox extension IDs are public identifiers (visible in the manifest and on AMO), so hardcoding the value directly is appropriate here rather than using a secret.Confidence Score: 5/5
Safe to merge — small, focused change with no correctness or security concerns.
The change is minimal and correct: it adds the required extension ID env var for wxt's AMO submission. The value is a public identifier, not a secret, so inline hardcoding is fine.
No files require special attention.
Important Files Changed
Reviews (1): Last reviewed commit: "chore: add FIREFOX_EXTENSION_ID to exten..." | Re-trigger Greptile