Skip to content

chore: add FIREFOX_EXTENSION_ID to extension workflow environment variables#397

Merged
SuperCoolPencil merged 1 commit intomainfrom
fix-amo
Apr 20, 2026
Merged

chore: add FIREFOX_EXTENSION_ID to extension workflow environment variables#397
SuperCoolPencil merged 1 commit intomainfrom
fix-amo

Conversation

@SuperCoolPencil
Copy link
Copy Markdown
Member

@SuperCoolPencil SuperCoolPencil commented Apr 20, 2026

Greptile Summary

Adds FIREFOX_EXTENSION_ID: surge@surge-downloader.com to the Submit to AMO step's environment variables in the extension workflow. Firefox extension IDs are public identifiers (visible in the manifest and on AMO), so hardcoding the value directly is appropriate here rather than using a secret.

Confidence Score: 5/5

Safe to merge — small, focused change with no correctness or security concerns.

The change is minimal and correct: it adds the required extension ID env var for wxt's AMO submission. The value is a public identifier, not a secret, so inline hardcoding is fine.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/extension.yml Adds FIREFOX_EXTENSION_ID as a plaintext env var to the AMO submission step; value is a public extension identifier, not sensitive

Reviews (1): Last reviewed commit: "chore: add FIREFOX_EXTENSION_ID to exten..." | Re-trigger Greptile

@SuperCoolPencil SuperCoolPencil merged commit 6727801 into main Apr 20, 2026
7 checks passed
@SuperCoolPencil SuperCoolPencil deleted the fix-amo branch April 20, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant