fix: drain response body before signaling readiness in concurrent downloader to ensure connection reuse#407
Merged
SuperCoolPencil merged 4 commits intomainfrom Apr 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR fixes a connection-reuse bug in
prewarmConnectionswherereadywas signalled before the response body was drained and closed. Go'snet/httptransport only returns a connection to the idle pool after the body is fully consumed and closed, so signalling first meant consumers could start new requests before the connection was actually available, defeating prewarming. The fix drains and closes the body first, then signals — and the newTestPrewarmConnections_Reusetest validates this withhttptrace.Confidence Score: 5/5
Safe to merge — the change is minimal, correct, and directly validated by the new test.
The fix is a two-line reorder with a clear rationale backed by Go's transport contract. The prewarm request already uses bytes=0-0, so the body drained is a single byte and blocking the goroutine is negligible. The new test uses httptrace to confirm end-to-end connection reuse. No P0 or P1 issues found.
No files require special attention.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: comments" | Re-trigger Greptile