fix delete failed#418
Merged
SuperCoolPencil merged 4 commits intomainfrom Apr 27, 2026
Merged
Conversation
…ror constants across the engine, lifecycle, and service layers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Cannot delete a non-downloaded file #373
Greptile Summary
This PR fixes a delete-failure bug by making
Cancelidempotent (returningnilfor missing downloads) and replacing brittle string-matching in the TUI with a propererrors.Is(err, types.ErrNotFound)guard. It also consolidates scatteredfmt.Errorfliterals into a shared sentinel errors package ininternal/engine/types/errors.go.Confidence Score: 5/5
Safe to merge; only a P2 style inconsistency found.
All findings are P2. The core fix (idempotent Cancel + sentinel error guard in TUI) is correct and well-tested. The only gap is one missed fmt.Errorf in ResumeBatch that was not converted alongside the rest of the refactoring.
internal/processing/pause_resume.go — ResumeBatch cold path at line 217 still uses fmt.Errorf instead of types.ErrNotFound.
Important Files Changed
Prompt To Fix All With AI
Reviews (2): Last reviewed commit: "refactor: centralize error handling by d..." | Re-trigger Greptile
Context used: