Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR initializes the swanlab-core project for issue #1063 by establishing the foundational Go project structure.
- New Go package for API endpoints is created.
- Project’s module, README, and LICENSE files have been added.
- A GitHub workflow for testing the core code is introduced.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/internal/api/api.go | Adds the API package with documentation metadata comments. |
| core/go.mod | Introduces the module declaration and Go version requirement. |
| core/README.md | Provides project overview and developer setup instructions. |
| core/LICENSE | Adds a LICENSE file referencing a higher-level LICENSE file. |
| .github/workflows/test-core.yml | Implements a GitHub Actions workflow for testing the core code. |
Comments suppressed due to low confidence (2)
core/LICENSE:1
- The LICENSE file contains only a reference to '../LICENSE'. To avoid confusion, consider including the full license text or clarifying its purpose.
../LICENSE
core/README.md:47
- [nitpick] The 'Env' section is incomplete. Please provide the necessary environment setup information or remove the placeholder if not needed.
TODO
Kaikaikaifang
approved these changes
Jun 10, 2025
SAKURA-CAT
added a commit
that referenced
this pull request
Jun 11, 2025
SAKURA-CAT
added a commit
that referenced
this pull request
Jun 11, 2025
* feat: init go project (#1064) * feat: add proto and grpc * feat: add proto build script * fix: golangci lint * feat: support auto or specify select port * chore: license * chore: add .golangci.yml * fix: use log/slog instead of log * chore: del core vendor --------- Co-authored-by: Kang Li <79990647+SAKURA-CAT@users.noreply.github.com>
SAKURA-CAT
added a commit
that referenced
this pull request
Jun 15, 2025
* feat: init go project (#1064) * fix: license use symlink (#1067) * Feature/protobuf: hello-word (#1074) * feat: init go project (#1064) * feat: add proto and grpc * feat: add proto build script * fix: golangci lint * feat: support auto or specify select port * chore: license * chore: add .golangci.yml * fix: use log/slog instead of log * chore: del core vendor --------- Co-authored-by: Kang Li <79990647+SAKURA-CAT@users.noreply.github.com> * feat: impl health checker and init data collector (#1077) * feat: impl health checker and init data collector * chore: change module name --------- Co-authored-by: KAAANG <79990647+SAKURA-CAT@users.noreply.github.com> * Feat/record proto and column parser (#1091) Co-authored-by: kaikai <2837968358@qq.com> * fix: import module and typo --------- Co-authored-by: Kaikai <98205900+Kaikaikaifang@users.noreply.github.com> Co-authored-by: kaikai <2837968358@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initialize swanlab-core project for #1063
CI Workflow Setup
.github/workflows/test-core.yml: Added a GitHub Actions workflow to lint and testswanlab-coreon multiple operating systems and Go versions.Documentation and Licensing
core/README.md: Added a detailed README file explaining the purpose ofswanlab-core, IDE setup, linter usage, and development environment configuration.core/LICENSE: Linked the license file to thecoredirectory.Project Setup
core/go.mod: Initialized the Go module forswanlab-corewith Go version1.24.4.API Scaffolding
core/internal/api/api.go: Added an initial API file with metadata comments describing its purpose for handling requests to SwanLab-Server.