fix: Progress bar should be based on cow orders and not on order slots #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f823344
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e226a3c0.stackly-ui.pages.dev |
| Branch Preview URL: | https://stk-112-progress-bar-should.stackly-ui.pages.dev |
ElRodrigote
approved these changes
Aug 11, 2023
berteotti
approved these changes
Aug 14, 2023
Diogomartf
deleted the
stk-112-progress-bar-should-be-based-on-cow-orders-and-not-on-time
branch
berteotti
pushed a commit
that referenced
this pull request
Oct 19, 2023
#45) * fix: remove totalOrders function and rename totalOrdersDone to totalOrderSlotsDone * fix: use StackOrder to define orders progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progress bar should be based on cow orders and not on order slots, this was causing a bug of showing progress without orders.
Screenshot
