-
Notifications
You must be signed in to change notification settings - Fork 3
[STK-62] Stackly header and logo #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Latest commit: |
2052cb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10174411.stackly-ui.pages.dev |
| Branch Preview URL: | https://feature-stk-62-stackly-heade.stackly-ui.pages.dev |
|
Can you update .gitignore so there aren't build files on our repo? |
|
There is a mobile version on figma. Stackly header should adjust itself if is rendered on mobile or desktop. |
1 similar comment
|
There is a mobile version on figma. Stackly header should adjust itself if is rendered on mobile or desktop. |
Its yarn cache and its required. Its not build files |
Will add the mobile classes. Mobile version I saw now. |
9d2bb08 to
2beac8a
Compare
0424999 to
30a74da
Compare
berteotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Velu, header looks nice. Just wondering if we should have the mobile logic all in the same component, using components like the placeholders and your stacks link in just 1 place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good work Velu.
I've made a lot of components but mostly are about tailwindcss.
I think in the upcoming PRs will be better at tailwind, so I took more time on this one.
Also adding a small description of the work and screenshot in the PR description would be awesome.
Let's fix these minor issues and ship the navbar.
0ce0121 to
7862350
Compare
Thank you. It's been some time since I used Tailwind. Going forward this issue will not occur. |
8b704d1 to
894c997
Compare
|
Just that small change and I think is ready ✔️ |
|
Hey Velu, I advise you to download this vscode extension if you haven't already. It's pretty useful for this cases https://marketplace.visualstudio.com/items?itemName=bradlc.vscode-tailwindcss |
894c997 to
62693a1
Compare
berteotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think about the constant
berteotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Velu!




Description