Error annotations from post-run step

[Nemo157]

In https://github.com/Nullus157/.github/actions/runs/5048663303 I'm seeing a bunch of error annotations:

Error: ENOENT: no such file or directory, opendir '/home/runner/.cargo/registry/index'

stepping into one of the jobs these are coming from the post-run action when it goes to clean the registry before caching, presumably because I have no dependencies so no registry data is downloaded https://github.com/Nullus157/.github/actions/runs/5048663303/jobs/9057129303#step:7:31 (this workflow is using rust-cache implicitly via actions-rust-lang/setup-rust-toolchain).

[Nemo157]

Just noticed on another project there's a similar annotation on jobs that don't create target, like running cargo fmt

Error: ENOENT: no such file or directory, opendir '/home/runner/work/bs58-rs/bs58-rs/target'

[Swatinem]

There is a ton of places where we guard try/catch and log errors. I believe this is just a log, and does not interfere with the rest of the action, so you should be able to just ignore this. ofc it would be nicer to ignore that error completely

[Nemo157]

Yeah, this doesn't fail the action, but it's a little more than just a log, it gets shown up at the top level of the run along with actual errors which make it harder to see why a run failed.

[rivy]

I think that a missing directory/file while trying to clean and remove it should be a non-error. If so, adding something like

if ((e as any)?.code === "ENOENT") { continue; }

to the catch statements in the several "...Cleaning..." code sections in save.ts could clear up several of the possible error messages.

rust-cache/src/save.ts

Lines 42 to 44 in 988c164

	} catch (e) {
	core.error(`${(e as any).stack}`);
	}

rust-cache/src/save.ts

Lines 51 to 53 in 988c164

	} catch (e) {
	core.error(`${(e as any).stack}`);
	}

rust-cache/src/save.ts

Lines 58 to 60 in 988c164

	} catch (e) {
	core.error(`${(e as any).stack}`);
	}

rust-cache/src/save.ts

Lines 65 to 67 in 988c164

	} catch (e) {
	core.error(`${(e as any).stack}`);
	}

[filips123]

This also happens in my project, once in a job where only rustfmt is run so no target is generated, and once when I conditionally build the crate. I agree with others that even though it's just a log message, it's quite annoying as it's displayed on the main workflow page:

Potentially, this could also make it harder to identify real problems with the build. So, I also agree that this error message should be hidden, or somehow prevented from showing up on the main page.