Conversation
nikitavoitsekhovskyi
suggested changes
Apr 21, 2024
Comment on lines
+227
to
+263
| const errorLogDTO = ( | ||
| eid: string, | ||
| pid: string, | ||
| pg: string, | ||
| dv: string, | ||
| br: string, | ||
| os: string, | ||
| lc: string, | ||
| cc: string, | ||
| rg: string, | ||
| ct: string, | ||
| name: string, | ||
| message: string, | ||
| lineno: number, | ||
| colno: number, | ||
| filename: string, | ||
| ): Array<string | number | string[]> => { | ||
| return [ | ||
| eid, | ||
| pid, | ||
| pg, | ||
| dv, | ||
| br, | ||
| os, | ||
| lc, | ||
| cc, | ||
| rg, | ||
| ct, | ||
| name, | ||
| message, | ||
| lineno, | ||
| colno, | ||
| filename, | ||
| dayjs.utc().format('YYYY-MM-DD HH:mm:ss'), | ||
| ] | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Put the DTO in a separate file.
Comment on lines
+328
to
+348
| const getEIDsArray = (eids, eid) => { | ||
| const eidsEmpty = _isEmpty(eids) | ||
| const eidEmpty = _isEmpty(eid) | ||
| if (eidsEmpty && eidEmpty) { | ||
| throw new BadRequestException( | ||
| "An array of Error ID's (eids) or a Error ID (eid) has to be provided", | ||
| ) | ||
| } | ||
| if (!eidsEmpty && !eidEmpty) { | ||
| throw new BadRequestException( | ||
| "Please provide either an array of Error ID's (eids) or a Error ID (eid), but not both", | ||
| ) | ||
| } | ||
|
|
||
| if (!eidsEmpty) { | ||
| return eids | ||
| } | ||
|
|
||
| return [eid] | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Take the function out to the service.
| ] as const) { | ||
| @ApiProperty() | ||
| @IsNotEmpty() | ||
| eid: string |
Contributor
There was a problem hiding this comment.
Name the field better errorId.
Comment on lines
+12
to
+14
| take: number | ||
|
|
||
| skip: number |
Contributor
There was a problem hiding this comment.
Validate it!!!
|
Any idea on when this will be available in the docker version? |
Member
Author
soon, I promise. I'll fix a few bugs related to timezones first and will start working on a new selfhosted release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket:
Self-hosted support
Database migrations
Documentation