Skip to content

- Adjust for missing altitude and team_id, default to None.#8

Merged
egelja merged 1 commit intoSwimComm:masterfrom
hansenmc:int_or_none
Aug 12, 2024
Merged

- Adjust for missing altitude and team_id, default to None.#8
egelja merged 1 commit intoSwimComm:masterfrom
hansenmc:int_or_none

Conversation

@hansenmc
Copy link
Copy Markdown
Contributor

  • Adjust types to be int|None
  • added tests to cover Swimmer and Meet
  • adjust test of version

Resolves issue #6 and issue #7

- Adjust types to be int|None
- added tests to cover Swimmer and Meet
- adjust test of __version__
Copy link
Copy Markdown
Contributor

@egelja egelja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants