Patch: add japanese flag

[konrad2002]

Summary by CodeRabbit

• Bug Fixes
  • Corrected country code mapping for Japan to ensure proper handling in the application.

[coderabbitai]

📝 Walkthrough

Walkthrough

A single mapping entry was added to the countryFlags constant, linking the country code "JPN" to its flag code "JP" in the countryflags.constant.ts configuration file.

Changes

Cohort / File(s)	Summary
Country Flags Mapping src/app/core/constant/countryflags.constant.ts	Added "JPN" → "JP" entry to the exported countryFlags map.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• Patch: add flags for Spain, Switzerland and Austria #123: Modifies the same countryFlags map constant to add country-code-to-flag mappings.

Poem

🐰 A flag for Japan now finds its place,
JPN to JP—a mapping embrace! 🎌
One line, one entry, yet the world grows wide,
In our constants, all nations reside! 🌍

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'add japanese flag' accurately describes the single change: adding a JPN→JP entry to the countryFlags map for Japanese flag support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/app/core/constant/countryflags.constant.ts (1)

1-10: Consider alphabetical ordering for easier maintenance.

While the current implementation is functionally correct, sorting the map entries alphabetically would make it easier to locate existing entries and avoid duplicates as the list grows.

📋 Proposed alphabetical ordering

 export const countryFlags = new Map<string, string>([
+    ["AUT", "AT"],
+    ["CZE", "CZ"],
+    ["ESP", "ES"],
     ["GER", "DE"],
-    ["CZE", "CZ"],
-    ["UKR", "UA"],
+    ["JPN", "JP"],
     ["POL", "PL"],
-    ["ESP", "ES"],
     ["SUI", "CH"],
-    ["AUT", "AT"],
-    ["JPN", "JP"]
+    ["UKR", "UA"]
 ]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/app/core/constant/countryflags.constant.ts` around lines 1 - 10, Reorder
the entries in the exported Map countryFlags so they are alphabetically sorted
by the 3-letter country code keys (e.g., "AUT", "CZE", "ESP", ...), preserving
the same key→value pairs and keeping the Map literal insertion order; update the
entries in countryflags.constant.ts accordingly to make lookups and maintenance
easier.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/app/core/constant/countryflags.constant.ts`:
- Around line 1-10: Reorder the entries in the exported Map countryFlags so they
are alphabetically sorted by the 3-letter country code keys (e.g., "AUT", "CZE",
"ESP", ...), preserving the same key→value pairs and keeping the Map literal
insertion order; update the entries in countryflags.constant.ts accordingly to
make lookups and maintenance easier.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1d5eb882-0b2f-40c0-bed8-00f3c4efcc4b

📥 Commits

Reviewing files that changed from the base of the PR and between a30829a and 9712ec0.

📒 Files selected for processing (1)

• src/app/core/constant/countryflags.constant.ts