Skip to content

Patch: sort results by time and enumerate ranks#129

Merged
konrad2002 merged 1 commit intomasterfrom
develop
Apr 19, 2026
Merged

Patch: sort results by time and enumerate ranks#129
konrad2002 merged 1 commit intomasterfrom
develop

Conversation

@konrad2002
Copy link
Copy Markdown
Member

@konrad2002 konrad2002 commented Apr 19, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Age group rankings for race events are now properly calculated based on competitor results, with correct handling of finish times and special cases.

@konrad2002 konrad2002 self-assigned this Apr 19, 2026
@konrad2002 konrad2002 changed the title sort results by time and enumerate ranks Patch: sort results by time and enumerate ranks Apr 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7ec631a6-e0c7-4c15-95fd-361e785f5d50

📥 Commits

Reviewing files that changed from the base of the PR and between e86590a and f1cefb4.

📒 Files selected for processing (1)
  • src/app/content/events/components/event-view/event-view.component.ts

📝 Walkthrough

Walkthrough

The fetchResultStarts() method's age-group rank reassignment logic for result-mode was re-enabled. Previously commented-out code now iterates through starts, assigns rank 0 for disqualified or missing-result entries, and applies ranking based on result times while handling ties via skipped-rank accounting.

Changes

Cohort / File(s) Summary
Rank Reassignment Logic Restoration
src/app/content/events/components/event-view/event-view.component.ts
Re-enabled age-group rank reassignment in fetchResultStarts(). Code now iterates through starts, sets rank to 0 for disqualified/missing-result entries, assigns sequential ranks based on result times, and accounts for ties via skippedRanks counter advancement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Ranks were sleeping, oh what a shame,
Now they awaken to join the game,
Ties are tied up, and zeros assigned,
The race results finally aligned!
Hopping through logic, all ranks in place,

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@konrad2002 konrad2002 merged commit 267d077 into master Apr 19, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant