Update PMD4 validations to reflect current muttnik expectations (#1249) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DatasetExactlyOneContents -> DatasetMaxOneContents - DatasetExactlyOneGraph -> DatasetMinOneGraph - DatasetExactlyOneLabel removed - DatasetExactlyOneTitle added - DatasetMaxOneContributor removed - RecordExactlyOneLabel removed
RickMoynihan
requested changes
Sep 28, 2021
Member
RickMoynihan
left a comment
RickMoynihan
left a comment
There was a problem hiding this comment.
Thanks for this @kieranlives.
The changes look great, I've suggested some minor bike shedding fixes... but I'm very happy for this to be merged once they've been made.
test/pmd4/swirrl/validations/pmd4/SELECT_DatasetExactlyOneTitle.ttl
Outdated
Show resolved
Hide resolved
test/pmd4/swirrl/validations/pmd4/SELECT_DatasetMaxOneContents.ttl
Outdated
Show resolved
Hide resolved
RickMoynihan
requested changes
Sep 28, 2021
Author
|
Er, I meant to write https://github.com/Swirrl/muttnik/pull/1327#issuecomment-937678328 on this PR! |
Member
|
@Robsteranium I've been through each of these and they seem good. And I've updated @kieranlives corresponding muttnik PR so it now passes wrt IC-19. https://github.com/Swirrl/muttnik/pull/1327 This means once that PR is merged, muttnik fixtures will be aligned with these changes. Are there any other comments on these changes? |
Open
|
I've merged this in to #24. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests with
clojure -M:test