Skip to content

chore: update nix isntall action#48

Merged
olevski merged 4 commits intomainfrom
chore-update-nix-action
Mar 5, 2026
Merged

chore: update nix isntall action#48
olevski merged 4 commits intomainfrom
chore-update-nix-action

Conversation

@olevski
Copy link
Copy Markdown
Member

@olevski olevski commented Feb 26, 2026

No description provided.

@olevski olevski requested a review from a team as a code owner February 26, 2026 14:42
Copy link
Copy Markdown
Member

@eikek eikek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@olevski olevski marked this pull request as draft February 26, 2026 14:49
@olevski
Copy link
Copy Markdown
Member Author

olevski commented Feb 26, 2026

I get weird nix errors. I have to install nix locally and try to troubleshoot.

@eikek
Copy link
Copy Markdown
Member

eikek commented Feb 27, 2026

It looks like the update to Cargo.toml is incompatible with the build pipeline.

I/O operation failed: parse error: parse error: invalid Cargo.lock format version: `4`

Perhaps a nix flake update helps.

@olevski
Copy link
Copy Markdown
Member Author

olevski commented Mar 4, 2026

@eikek should we just run the tests by setting up the run environment via just github actions?

@olevski
Copy link
Copy Markdown
Member Author

olevski commented Mar 4, 2026

Then you can fix the nix stuff in a followup pr so that we still can use that as a working dev environment.

@eikek
Copy link
Copy Markdown
Member

eikek commented Mar 5, 2026

I don't think it's the nix code that is the issue. There are now vulnerabilities reported, which is why the check action fails.
Example:

crate-audit> Crate:     bytes
crate-audit> Version:   1.9.0
crate-audit> Title:     Integer overflow in `BytesMut::reserve`
crate-audit> Date:      2026-02-03
crate-audit> ID:        RUSTSEC-2026-0007

I can take care if you want. I guess we need to update some dependencies etc.

eikek added 2 commits March 5, 2026 09:58
- minimal update dependencies to address advisory issues
- fix clippy errors
@eikek eikek self-requested a review March 5, 2026 09:35
@olevski olevski marked this pull request as ready for review March 5, 2026 09:36
@olevski
Copy link
Copy Markdown
Member Author

olevski commented Mar 5, 2026

Thank you Eike!!!

@olevski olevski merged commit 6d9fac2 into main Mar 5, 2026
5 checks passed
@olevski olevski deleted the chore-update-nix-action branch March 5, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants