Skip to content

Conversation

@mohammad-alisafaee
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Description

Document for renku dataset update

Fixes #763

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Do not create pull request unless you checked all points.

@mohammad-alisafaee mohammad-alisafaee requested a review from a team as a code owner October 22, 2019 14:16
After adding files from a remote Git repository, you can check for updates in
those files by using ``renku dataset update`` command. This command checks all
remote files and copies over new content if there are any. It also deletes
files from the local dataset if they are deleted from the remote Git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I hadn't thought of that before but I guess this will lead to some unexpected behavior. Is there an issue already for updating to a specific commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. It was supposed to be part of this one but I decided to do it later. I'll create on when we close this one. I don't see though how that would help; if a file is deleted from the latest update eventually we need a way to deal with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure, but right now I can imagine someone could do an update that deleted a file with no way to get back other than doing a git reset. If they were able to go to a previous commit it would be a non-issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, this is not the right place for this discussion I realize :) We should add support for updating to a specific commit reasonably soon to avoid having users that get stuck in some strange state.

Copy link
Contributor Author

@mohammad-alisafaee mohammad-alisafaee Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, I'll ask the user to provide an explicit flag for deletion.

You can limit the scope of updated files by specifying dataset names, using
``--include`` and ``--exclude`` to filter based on file names, or using
``--creators`` to filter based on creators. For example, the following command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creators - as determined by the email?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is the full name of the creator. This is like some other dataset subcommands (e.g. ls-files)

@mohammad-alisafaee
Copy link
Contributor Author

I'll add changes in this PR to #765 and close this one.

@mohammad-alisafaee mohammad-alisafaee deleted the 763-dataset-update-docs branch October 25, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add dataset update to the docs

3 participants