Skip to content

fix: service dataset.create with additional metadata #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2020
Merged

fix: service dataset.create with additional metadata #875

merged 2 commits into from
Jan 6, 2020

Conversation

@jsam
Copy link
Contributor

@jsam jsam commented Dec 18, 2019 •
edited
Loading

closes: #874

  • improves the interface of dataset create for the service needs
  • addresses a problems raised by linter
  • adds ability to set metadata from the service

@jsam jsam requested a review from a team as a code owner December 18, 2019 07:39
@jsam jsam force-pushed the 874_svc_dataset_create branch 2 times, most recently from 22fc5e2 to ee1277a Compare December 18, 2019 10:40
@jsam jsam mentioned this pull request Dec 18, 2019
Merged
Panaetius
Panaetius approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thank you!

@rokroskar rokroskar merged commit 92ca37a into master Jan 6, 2020
@rokroskar rokroskar deleted the 874_svc_dataset_create branch January 6, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Panaetius Panaetius Panaetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RaaS: Use additional metadata on dataset creation

4 participants

@jsam @Panaetius @rokroskar