chore: remove legacy components - sessions+notebooks#3981
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3981.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
lorenzo/remove-legacy-p2
branch
from
a5c16a7 to
6f9ae77
Compare
lorenzo-cavazzi
force-pushed
the
lorenzo/remove-legacy-p3
branch
from
408b1f1 to
81902aa
Compare
leafty
reviewed
Jan 22, 2026
| import { Loader } from "./Loader"; | ||
| import ScrollableModal from "./modal/ScrollableModal"; | ||
|
|
||
| interface NotebookAnnotations { |
Member
There was a problem hiding this comment.
Can we keep this type in a separate source file?
| <Routes> | ||
| <Route path="/" element={<ProjectSettingsGeneral {...props} />} /> | ||
| <Route path="sessions" element={<ProjectSettingsSessions />} /> | ||
| <Route path="sessions" element={null} /> |
| type ResponseNamespaces = GetNamespacesApiResponse["namespaces"]; | ||
| type ResponseNamespace = ResponseNamespaces[number]; | ||
|
|
||
| interface PaginatedState<T = unknown> { |
Member
There was a problem hiding this comment.
Same here: put this type in a better location (e.g. pagination).
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove sessions and related components.
Mind that v2 sessions are still fetched in response to messages from the WebSocket component.
/deploy