chore: remove legacy components - markdown+lineage+file#3982
Conversation
|
You can access the deployment of this PR at https://renku-ci-ui-3982.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
lorenzo/remove-legacy-p3
branch
from
408b1f1 to
81902aa
Compare
lorenzo-cavazzi
force-pushed
the
lorenzo/remove-legacy-p4
branch
from
121e55b to
d75b050
Compare
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
I think we can make mermaid work. Some people may already use it in project documentation so we cannot break it.
There was a problem hiding this comment.
This component name is too long. Why not <Markdown> and <LazyMarkdown>?
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
Code blocks are not processed how they are at the moment, see diff:
|
Also: |
|
You are right, we committed to support Math formulas as well. I don't think we need to support syntax highlighting (I haven't seen any mention in our documentation, we were doing that mainly for previewing files in the file browser) but it' a nice feature for sure so I re-added support for that through 
|
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
Nice! 🚀
Before:
build/client/assets/cytoscape.esm-CyJtwmzi.js 442.46 kB │ gzip: 141.94 kB │ map: 1,865.23 kB
build/client/assets/CodePreview-v5Qo1uoa.js 942.96 kB │ gzip: 303.97 kB │ map: 2,053.22 kB
build/client/assets/wrappedIndex-D0g9By73.js 1,812.18 kB │ gzip: 452.20 kB │ map: 6,150.08 kB
build/client/assets/RenkuMarkdown-38qaoafQ.js 2,201.26 kB │ gzip: 680.44 kB │ map: 6,219.43 kB
build/client/assets/NotebookRender-C3AAvu4X.js 2,947.29 kB │ gzip: 978.41 kB │ map: 4,811.10 kB
After:
build/client/assets/cytoscape.esm-CyJtwmzi.js 442.46 kB │ gzip: 141.94 kB │ map: 1,865.23 kB
build/client/assets/Markdown-Bp4rLUXm.js 1,230.84 kB │ gzip: 361.81 kB │ map: 4,591.72 kB
build/client/assets/wrappedIndex-DaPtgRRZ.js 1,811.46 kB │ gzip: 451.84 kB │ map: 6,148.97 kB
So we got a slimmer markdown renderer now!
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
3 participants
The Markdown components where integrating quite some logic to convert/rewrite links that we don't need anymore. I made another very lean component for showing Markdown content that supports everything (except Mermaid?)
/deploy