feat: use RTK Query for server-side data fetches#4043
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-4043.dev.renku.ch |
leafty
commented
Feb 24, 2026
leafty
commented
Feb 24, 2026
leafty
force-pushed
the
leafty/exp-ssr-fetch
branch
from
fda4e85 to
7274acc
Compare
leafty
force-pushed
the
leafty/exp-ssr-fetch
branch
from
7274acc to
c69ae41
Compare
lorenzo-cavazzi
previously approved these changes
Mar 10, 2026
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
This is a nice solution and it works well 👏 We can go on and merge it 🚀
I still wonder if we could take a different approach to keep the logic as simple as possible, like duplicating the query on the server side to fetch the information for the pre-viewable fields, leaving the existing client-side RTK queries unmodified.
leafty
commented
Mar 10, 2026
lorenzo-cavazzi
approved these changes
Mar 10, 2026
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the project overview and the project settings pages to be handled from
routes.tswith server-side API data loading (in production).This allows us to generate project-specific meta tags which is nice for sharing Renku projects in socials.
See meta tags example:
Important note: Sentry trace propagation is working, here is an example page load, with the included API request to get the project data server-side
/deploy extra-values=ui.client.resources.limits.memory=300Mi,ui.client.resources.requests.memory=300Mi,ui.client.sentry.enabled=false,ui.client.sentry.environment=renku-ci-ui-4043,ui.client.sentry.sampleRate=1,ui.client.sentry.dsn=https://b8aaa5810d2743f281350c0944c38ec8@o4509039310995456.ingest.de.sentry.io/4509044025131088