Skip to content

chore: upgrade eslint#4063

Merged
leafty merged 10 commits into
mainfrom
leafty/upgrade-eslint
Mar 6, 2026
Merged

chore: upgrade eslint#4063
leafty merged 10 commits into
mainfrom
leafty/upgrade-eslint

Conversation

@leafty
Copy link
Copy Markdown
Member

@leafty leafty commented Mar 4, 2026

Upgrade eslint to version 9. Note that the current version is 10, but some important plugins are not compatible yet.

Important changes:

  • The eslint configuration is completely different and is now found in eslint.config.msj. Our current setup has been migrated, though we should most likely revise the rules and re-enable important checks (e.g. prop types in react for javascript)
  • The React linters are now a lot more comprehensive and catch more code quality issues. This is why a lot of code files have been edited to have a TODO item to fix deviation from React rules.

A lot of the new issues flagged by eslint have to deal with the fact that setState() should not be used in synchronous code inside a useEffect(). The reasons why this is not a best practice is detailed in length in the React docs: https://react.dev/learn/you-might-not-need-an-effect.

/deploy

@leafty leafty marked this pull request as ready for review March 4, 2026 12:14
@leafty leafty requested a review from a team as a code owner March 4, 2026 12:14
@RenkuBot
Copy link
Copy Markdown
Contributor

RenkuBot commented Mar 4, 2026

You can access the deployment of this PR at https://renku-ci-ui-4063.dev.renku.ch

ciyer
ciyer previously approved these changes Mar 5, 2026
Copy link
Copy Markdown
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leafty leafty requested a review from ciyer March 6, 2026 13:24
@leafty leafty enabled auto-merge (squash) March 6, 2026 13:24
@leafty leafty merged commit dbcff0c into main Mar 6, 2026
21 of 23 checks passed
@leafty leafty deleted the leafty/upgrade-eslint branch March 6, 2026 13:34
@RenkuBot
Copy link
Copy Markdown
Contributor

RenkuBot commented Mar 6, 2026

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants