chore: upgrade eslint#4063
Merged
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-4063.dev.renku.ch |
ciyer
approved these changes
Mar 6, 2026
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
eslintto version 9. Note that the current version is 10, but some important plugins are not compatible yet.Important changes:
eslintconfiguration is completely different and is now found ineslint.config.msj. Our current setup has been migrated, though we should most likely revise the rules and re-enable important checks (e.g.proptypes in react for javascript)A lot of the new issues flagged by
eslinthave to deal with the fact thatsetState()should not be used in synchronous code inside auseEffect(). The reasons why this is not a best practice is detailed in length in the React docs: https://react.dev/learn/you-might-not-need-an-effect./deploy