feat: rework linking existing data connector#4084
Conversation
|
You can access the deployment of this PR at https://renku-ci-ui-4084.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
lorenzo/data-connector-modal
branch
2 times, most recently
from
e02ecb5 to
f8f7e8b
Compare
lorenzo-cavazzi
force-pushed
the
lorenzo/data-connector-modal
branch
from
2cf874d to
76c5e45
Compare
* add/improve links * compact result visualization
lorenzo-cavazzi
force-pushed
the
lorenzo/data-connector-modal
branch
from
7ae1563 to
8ee5b9a
Compare
There was a problem hiding this comment.
Great work!✨ One small UX thought: the row disappearing silently after linking might feel like a glitch to some users. A shrinking progress bar or a fade animation on the "Linked" badge would help signal that the row is about to go away. It makes the transition feel intentional instead of broken. Not a blocker, just a nice polish opportunity!
| } | ||
|
|
||
| // Tries to catch all the valid doi cases -- it returns the string directly, but we could consider reusing parseDoi to extract the initial string | ||
| export function normalizeAsDoi(input: string): string { |
There was a problem hiding this comment.
It would be great to add some unit tests for this
| const DC_SEARCH_SLUG_PREFIX = "slug:"; | ||
| const DC_SEARCH_NAMESPACE_PREFIX = "namespace:"; | ||
| const DC_SEARCH_DOI_PREFIX = "doi:"; | ||
| const SUCCESS_MESSAGE_TIMEOUT_MS = 10_000; |
There was a problem hiding this comment.
Suggest reducing this from 10_000 → 4_000.
10s feels like a hang, while 4s gives users enough time to register the “Linked” state before the row disappears without causing confusion.
There was a problem hiding this comment.
I agree that's a little long. I reduced it here 70d8202 and took the occasion to move constants to a separate file since there were many.
|
@andre-code we don't use animations in many places but I agree it would be useful in this case. I did something simple reusing the |
Beautiful ✨ It helps a lot!!! |
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
3 participants
This PR adds a new page to the Data Connector creation modal to simplify the reuse of existing data connectors. It adds minimal search capabilities and replaces the previous "doi" and "identifier" sections.
Reference pitch: https://www.notion.so/renku/Show-link-able-DCs-without-search-1260df2efafc80db95c5d605cc6a02bc
/deploy renku=lorenzo/data-connector-modal