fix: bootstrap icon sizes#4121
Merged
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-4121.dev.renku.ch |
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Nice fix 🎉
P.S. We probably want to handle sizes through classes like fs-x instead of fixed numbers, but the PR restores the previous state which is already great 👍
lorenzo-cavazzi
approved these changes
Apr 9, 2026
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the icon size for Bootstrap icons.
Icon size (for bootstrap icons) should now be controlled with the
fontSizeprop. The.biclass is added by thereact-bootstrap-iconspackage now so the icons are forced to be the same size as the font. (So to change the icon size, just change the font size)./deploy renku=release-2.16.0