Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds robust support for YAML block scalar "chomping" indicators (|, |-, |+) to both the reader and writer, ensuring correct handling of trailing newlines in multi-line strings. It also introduces logic to automatically use the literal block style when serializing multi-line strings and includes comprehensive tests to verify roundtripping and edge cases.
Block scalar chomping support:
_blockScalarChompingand logic to track and store the chomping indicator in bothParseLiteralBlockScalarandParseFoldedBlockScalarmethods inUtf8YamlReader.Parsing.csandUtf8YamlReader.cs. [1] [2] [3]ProcessBlockScalarContentto apply chomping rules: strip (-), keep (+), or clip (default), ensuring correct trimming or preservation of trailing newlines when reading block scalars. [1] [2] [3]Read()method to pass the chomping indicator toProcessBlockScalarContent.Writer improvements for multi-line strings:
WriteScalarValueinUtf8YamlWriter.csto auto-detect multi-line strings and serialize them using literal block style (|,|-, or|+) based on the string's trailing newlines, with a dedicatedWriteLiteralScalarValuehelper. [1] [2]Testing and validation:
PrimitiveSerializationTests.csto verify: