fix: prevent infinite loops in collection deserialization by skipping unexpected tokens#5
Merged
Merged
Conversation
… unexpected tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of collection and dictionary deserialization in the YAML source generator by ensuring the reader properly skips unexpected tokens, preventing potential infinite loops. It also enhances the
Skip()method in the YAML reader to correctly handle scalar values.Error handling and infinite loop prevention:
YamlSourceGenerator.csfor reading mappings, sequences, and dictionaries to callreader.Skip()when an unexpected token is encountered, avoiding infinite loops during deserialization. [1] [2] [3]Reader behavior improvements:
Skip()method inUtf8YamlReader.csto advance the reader when encountering scalar tokens (including nulls), ensuring scalars are properly skipped and not misinterpreted as structural tokens.