✨Feat: refetch events after Gcal Notification#126
Merged
Conversation
7 tasks
452fc31 to
f9eeece
Compare
adding client lib to backend helps simulate client behavior for testing. this lib should stay out of the prod 'dependencies' build, though, in order to encourage separation of concerns between server+client
motivation: so eslint warnings can show in test files
this'll decouple the view from the socket, and hopefully reduce the rerendering
.warning doesn't actually exist on winston.logger 😅
this enables accessing the userId lower in the component tree, like in the socket provider
restrict nulls in attempt to prevent websocket connection with 'null' id
refactor(web): separate view and sync state poc(wip): re-render after event change dispatched fix(web): prevent refresh when clicking tooltip wrapper chore(web): remove timeout from useRefresh
this, in combination with using the spinner, ensures that userId is always a string and not null
ac63fd7 to
316ca31
Compare
bee0889 to
49040eb
Compare
42f5eb7 to
aee3b86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in** WebSocket integration between client and server via
socket-iolibrarySummary
curl -X POST http://localhost:3000/api/event-change-demoVisual Summary
^ click image to expand
Usage
**To opt-in to this feature, add this to your
.env, replacing the example value with your userid:# .env DEMO_SOCKET_USER=your-mongodb-useridAlso includes the following changes that aren't directly related to WebSockets 🙈
isEventInRangesyncredux slice, moving some state there that was previously insettingsRelated Issue: #43