Skip to content

Comments

🐛 fix(recurring-events): create instances for someday recurrence#1080

Merged
victor-enogwe merged 7 commits intomainfrom
fix-create-instances-for-recurring-someday-events-1058
Oct 8, 2025
Merged

🐛 fix(recurring-events): create instances for someday recurrence#1080
victor-enogwe merged 7 commits intomainfrom
fix-create-instances-for-recurring-someday-events-1058

Conversation

@victor-enogwe
Copy link
Contributor

What does this PR do?

This PR updates the recurrence logic for someday events.
Someday event instances are now created alongside their base event.

Use Case

closes #1058

Copilot AI review requested due to automatic review settings October 7, 2025 12:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the recurrence logic for someday events by creating instance events alongside their base events. Previously, someday recurring events would only create base events without instances.

  • Added support for creating someday event instances when base events are created
  • Updated event categorization to include RECURRENCE_INSTANCE_SOMEDAY category
  • Modified filtering logic to exclude base events from someday queries while including instances

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/core/src/util/event/event.util.ts Refactored event type checking functions for better type safety
packages/core/src/types/event.types.ts Added new RECURRENCE_INSTANCE_SOMEDAY category and updated documentation
packages/core/src/mocks/v1/events/events.someday.1.ts Updated mock data to use ObjectId for better test consistency
packages/core/src/mocks/v1/events/events.22jan.ts Updated mock data to use ObjectId for better test consistency
packages/backend/src/sync/services/sync/compass.sync.processor.ts Updated transition handling to support someday instance events
packages/backend/src/sync/services/sync/tests/compass-sync-processor-this-event/instance.test.ts Updated test expectations for someday instance creation
packages/backend/src/sync/services/sync/tests/compass-sync-processor-this-event/base.test.ts Restructured tests to validate base event edit restrictions
packages/backend/src/event/services/event.service.util.ts Simplified filtering logic to exclude base events consistently
packages/backend/src/event/services/event.service.ts Modified instance creation logic to support someday events
packages/backend/src/event/services/event.find.test.ts Updated tests to validate new someday instance behavior
packages/backend/src/event/classes/compass.event.parser.ts Enhanced parser to handle someday instance creation and updates
packages/backend/src/event/classes/compass.event.parser.test.util.ts Updated test utility to expect instances for someday events
packages/backend/src/event/classes/compass.event.parser.test.ts Added proper import and updated test expectations
packages/backend/src/event/classes/compass.event.generator.ts Added validation to prevent direct base event editing
packages/backend/src/common/services/mongo.service.ts Made ObjectId parameter optional for better flexibility

Copilot AI review requested due to automatic review settings October 7, 2025 13:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

@victor-enogwe victor-enogwe requested review from a team and removed request for a team October 7, 2025 13:47
Copilot AI review requested due to automatic review settings October 8, 2025 09:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.

@victor-enogwe victor-enogwe merged commit 2f316fc into main Oct 8, 2025
4 checks passed
@victor-enogwe victor-enogwe deleted the fix-create-instances-for-recurring-someday-events-1058 branch October 8, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Someday recurrences aren't rendering in future weeks

2 participants