🐛 fix(recurring-events): fix ui recurring event transitions#1091
Merged
victor-enogwe merged 1 commit intomainfrom Oct 9, 2025
Merged
🐛 fix(recurring-events): fix ui recurring event transitions#1091victor-enogwe merged 1 commit intomainfrom
victor-enogwe merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bugs that disabled users' ability to transition recurring events to standalone events. The changes refactor how recurrence handling is managed in the UI, particularly around event form interactions and update scope detection.
- Simplifies recurrence toggle logic by removing form visibility state management
- Fixes recurring event update scope determination by properly detecting recurrence changes
- Introduces a utility component for conditional rendering to improve code clarity
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/src/views/Forms/EventForm/RecurringEventUpdateScopeDialog.tsx | Refactors to use DirtyParser for recurrence change detection and fixes priority handling |
| packages/web/src/views/Forms/EventForm/DateControlsSection/RecurrenceSection/components/RecurrenceToggle.tsx | Simplifies toggle logic by removing form visibility state and using ConditionalRender |
| packages/web/src/views/Forms/EventForm/DateControlsSection/RecurrenceSection/RecurrenceSection.tsx | Removes form visibility state management and switches to ConditionalRender |
| packages/web/src/views/Calendar/components/Draft/sidebar/hooks/useSidebarActions.ts | Adds proper recurrence change detection for event instance handling |
| packages/web/src/views/Calendar/components/Draft/hooks/state/useDraftConfirmation.ts | Fixes update scope determination for standalone event transitions |
| packages/web/src/views/Calendar/Calendar.tsx | Reorganizes imports and adjusts component positioning |
| packages/web/src/components/ConditionalRender/ConditionalRender.tsx | Adds new utility component for conditional rendering |
| packages/web/src/common/parsers/dirty.parser.ts | Makes recurrenceChanged method public for external usage |
packages/web/src/views/Forms/EventForm/RecurringEventUpdateScopeDialog.tsx
Show resolved
Hide resolved
.../views/Forms/EventForm/DateControlsSection/RecurrenceSection/components/RecurrenceToggle.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the bugs that disabled users ability to transition recurring events to standalone events.
Use Case
closes #1079
closes #1081