Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on styling improvements and test stabilization for the onboarding flow. The changes include adding proper flexbox layout to icon buttons for better SVG alignment, wrapping user interactions in test files with act() calls to fix React warnings, and removing a debug console.log statement.
- Improved icon button styling with flexbox centering
- Fixed React testing warnings by properly wrapping async user events in
act() - Removed debug logging from production code
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web/src/views/Onboarding/components/IconButtons.tsx | Added flexbox layout properties to center SVG icons within buttons |
| packages/web/src/views/Onboarding/steps/events/SomedaySandbox/useSomedaySandbox.ts | Removed debug console.log statement from submission guard |
| packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.test.tsx | Wrapped userEvent calls in act() to properly handle async state updates and moved act import |
packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.test.tsx
Outdated
Show resolved
Hide resolved
…in SomedaySandbox tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the minor styling and test requirements from #1128
Before
After
Arrows are centered