fix(web): convert pop up error as cancellation#1516
Merged
tyler-dane merged 11 commits intomainfrom Mar 7, 2026
Merged
Conversation
Contributor
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 6. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Contributor
Author
|
@cursoragent fix test failures |
Contributor
|
Fixed the test failures. The tests were using synchronous queries ( Changes MadeI updated the failing tests in
This addresses timing issues in CI where elements weren't immediately available after render. All tests now pass locally (195 test suites, 1543 tests), and the changes have been committed and pushed to the branch. |
tyler-dane
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Replace getByRole/getByText with findByRole/findByText to wait for components to render before assertions. This fixes timing-related test failures in CI where elements weren't immediately available after render. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
- Removed unused import from promise.middleware.test.ts to improve clarity. - Simplified condition in sendResponse function of promise.middleware.ts for better readability. - Updated import path for Google OAuth error utility in useGoogleLogin.ts to reflect new directory structure.
tyler-dane
force-pushed
the
cursor/posthog-error-investigation-7e18
branch
from
fcb7eb7 to
e8137bb
Compare
… file - Adjusted the import statement in `google-oauth-error.util.test.ts` to reflect the new directory structure for better organization and clarity.
- Eliminated console log statements from data and external migration functions to reduce clutter and improve performance. - Updated the demo data seed migration to skip seeding when existing data is present, enhancing efficiency. - Added console method spies in test files to control logging behavior during tests, improving test clarity and reducing noise.
- Deleted the `google-oauth-preview.png` and `logo.png` files from the assets directory as they are no longer needed, streamlining the asset management.
- Replaced synchronous rendering methods with asynchronous counterparts in various test files to ensure proper initialization and avoid timing issues. - Updated utility functions to prepare storage for tests, enhancing the clarity and reliability of the test environment. - Removed unused imports and streamlined test setups across multiple components, improving overall code organization and readability.
- Changed the test command in package.json from "cross-env-shell" to "cross-env" for improved compatibility and consistency across environments.
- Updated the DraggableTask component to conditionally enable the drag handle based on the number of tasks, enhancing user experience. - Refactored the floating behavior to only activate when the drag handle is visible and not in test environments, improving performance and reliability. - Simplified the reference setting logic for the floating element, ensuring it only attaches when necessary.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
- Introduced a new setup file to mock @floating-ui/react, allowing tests to run without real layout calculations. - Updated TaskContextMenu and TaskList test files to include the new floating-ui mock, ensuring consistent behavior across tests. - Simplified the DraggableTask component by removing environment checks for floating behavior, enhancing test reliability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Error: Popup window closed" in Posthog by treating Google OAuth popup cancellations as benign user actions instead of errors.