docs(web): clarify google oauth popup cancellation behavior#1525
Merged
tyler-dane merged 1 commit intomainfrom Mar 7, 2026
Merged
docs(web): clarify google oauth popup cancellation behavior#1525tyler-dane merged 1 commit intomainfrom
tyler-dane merged 1 commit intomainfrom
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update frontend runtime and file-map docs to describe how Google OAuth popup-close outcomes are classified and handled in the web auth flow, including the exact codepaths and state transitions for cancellation vs. true auth errors.
Note
Low Risk
Docs-only changes; no runtime behavior, auth, or data-handling logic is modified.
Overview
Updates web docs to explicitly document Google OAuth popup-close as a cancellation path (not an auth failure), including the exact cancellation detection rules used by
isGooglePopupClosedErrorand the resulting state transitions (reset auth + clear import/progress flags, without dispatching generic auth-failure).Extends
docs/feature-file-map.mdto include the key Google OAuth hook/wrapper/util files so reviewers can quickly find the relevant codepaths.Written by Cursor Bugbot for commit a3dcf01. This will update automatically on new commits. Configure here.