refactor: uppercase status for consistency#1538
Merged
tyler-dane merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
- Replaced `CheckCircleIcon` with `LinkIcon` in the Google connection status to better represent the connection state. - Adjusted type definitions and related components to reflect the icon change, ensuring consistency across the application. - Cleaned up unused imports in the `TaskCircleIcon` component for improved code clarity.
…rcase - Updated all instances of Google connection status values to use uppercase naming conventions: "NOT_CONNECTED", "CONNECTED", and "RECONNECT_REQUIRED". - Adjusted related tests and components to reflect these changes, ensuring consistency across the application. - Improved clarity and maintainability of the user metadata handling logic by adhering to a unified naming standard.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| | "not_connected" | ||
| | "reconnect_required" | ||
| | "NOT_CONNECTED" | ||
| | "RECONNECT_REQUIRED" |
Contributor
There was a problem hiding this comment.
Inconsistent casing within GoogleUiState type values
Low Severity
The GoogleUiState type now mixes UPPER_CASE ("NOT_CONNECTED", "RECONNECT_REQUIRED") with snake_case ("checking", "connected_healthy", "connected_repairing", "connected_attention"). Before this PR, all values were consistently snake_case. In a PR aiming for casing consistency, this introduces a new inconsistency within a single union type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple renaming follow up to #1535
Note
Medium Risk
Changes the
GoogleConnectionStatusstring contract across core types, backend metadata assessment, websocket payload expectations, and multiple web UI paths; any missed caller could mis-handle connection state. Mostly mechanical renames plus a small UI icon change, so behavior should be stable if all references were updated.Overview
Standardizes Google Calendar
connectionStatusvalues to uppercase (NOT_CONNECTED/CONNECTED/RECONNECT_REQUIRED) across the sharedGoogleConnectionStatustype, backendUserMetadataServiceassessment logic, and websocket/user-metadata tests.Updates web client state handling to match the new enum values (including auto-import gating in
useGcalSyncand defaults inuseConnectGoogle) and swaps the “connected” sidebar icon fromCheckCircleIcontoLinkIcon(with adjusted color). Also includes small test/typing cleanup (UserApicast) and removal of an unusedReactimport.Written by Cursor Bugbot for commit 6458171. This will update automatically on new commits. Configure here.