Skip to content

dependencies: fix warnings#1546

Merged
tyler-dane merged 16 commits intomainfrom
dependencies/fix-warnings
Mar 21, 2026
Merged

dependencies: fix warnings#1546
tyler-dane merged 16 commits intomainfrom
dependencies/fix-warnings

Conversation

@tyler-dane
Copy link
Copy Markdown
Contributor

@tyler-dane tyler-dane commented Mar 16, 2026

Note

Medium Risk
Switching the repo to Yarn 4/Corepack and changing install/build tooling can break CI or local builds if the environment isn’t aligned. UI/test updates are low risk but touch accessibility semantics and E2E synchronization logic.

Overview
Migrates the monorepo to Yarn 4 by updating docs/CI to use corepack enable and yarn install --immutable, adding .yarnrc.yml (including httpTimeout and packageExtensions), ignoring .yarn/, and updating root package.json (packageManager, workspace config, and glob pin via resolutions/overrides). It also removes the Copilot setup workflow.

Build and dependency tooling is adjusted: the scripts web build now runs yarn webpack ..., and the node build switches production installs to npm install --omit=dev --ignore-scripts for better cross-Yarn reliability.

Sidebar connection status becomes more accessible and tests more deterministic: SidebarIconRow wraps the Google status tooltip in a role="status" container (icons become aria-hidden), unit tests assert via getByRole("status"), and Playwright OAuth/sidebar tests replace timeouts with semantic/aria-label waits while blocking /api/user/metadata to avoid state races.

Written by Cursor Bugbot for commit f06868a. This will update automatically on new commits. Configure here.

- Added "@types/node" dependency to package.json for improved TypeScript support.
- Updated "@emnapi/core" and "@emnapi/runtime" to version 1.9.0 in yarn.lock.
- Updated various "@InQuirer" packages to their latest versions for enhanced functionality and bug fixes.
- Added resolutions for "glob" and "rimraf" to ensure consistent dependency versions across the project.
- Introduced a new .yarnrc.yml file to configure the node linker for Yarn 4+.
- Added "@types/node" dependency to package.json for improved TypeScript support.
- Updated package.json to use npm for production installs, enhancing reliability across Yarn versions.
- Adjusted workspaces configuration in package.json for better organization.
@tyler-dane tyler-dane force-pushed the dependencies/fix-warnings branch from a567675 to 518ed11 Compare March 17, 2026 18:46
@tyler-dane tyler-dane marked this pull request as ready for review March 19, 2026 03:49
Comment thread .github/workflows/test-e2e.yml Outdated
Comment thread packages/scripts/src/commands/build.util.ts Outdated
@tyler-dane
Copy link
Copy Markdown
Contributor Author

@cursoragent update branch with main, resolve conflicts , and address your concerns

@cursor
Copy link
Copy Markdown
Contributor

cursor Bot commented Mar 21, 2026

❌ Unable to add follow-up after multiple attempts. The agent may be experiencing issues.

Please try again later or Open in Web to view the status.

Open in Web Open in Cursor 

Learn more about Cursor Agents

- Updated Yarn version in package.json from 4.9.1 to 4.13.0 for improved features and performance.
- Added .yarn/install-state.gz to .gitignore to prevent unnecessary files from being tracked.
- Introduced new dependencies in packages/web/package.json: react-is, rxjs, @testing-library/dom, prettier, and typescript, along with updates to existing dependencies for better compatibility and functionality.
…lution

- Introduced package extensions in .yarnrc.yml to address peer dependency warnings for several packages, including @types/react-datepicker, babel-plugin-styled-components, styled-components, eslint-plugin-jest, eslint-plugin-testing-library, and ts-node-dev.
- This change ensures that missing peerDependencies are correctly declared, improving compatibility and reducing warnings during installation.
@tyler-dane tyler-dane force-pushed the dependencies/fix-warnings branch from 0012824 to e914d52 Compare March 21, 2026 16:33
- Added a step to enable Corepack in the GitHub Actions workflows for E2E, unit, and copilot setup, ensuring consistent package management across the CI environment.
- Eliminated redundant Corepack enable steps from the GitHub Actions workflows for E2E, unit, and copilot setup, streamlining the CI configuration.
- Deleted the `.github/copilot-instructions.md` file and the `copilot-setup-steps.yml` workflow to streamline the repository and eliminate unused configurations.
Comment thread .github/workflows/test-unit.yml
…ities

- Updated waitForTimeout values from 50ms to 100ms in setIsSyncing and setGoogleConnectionState functions to allow more time for React to process state changes and ensure consistent behavior during CI runs.
- Enhanced comments for clarity regarding the purpose of the delays.
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 3 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issues.

Comment thread package.json Outdated
Comment thread package.json Outdated
…lendar

- Renamed SIDEBAR_ICON_LABELS to SIDEBAR_STATUS_LABELS to better reflect their purpose.
- Updated tests to verify the sidebar connection status using aria-label attributes instead of icons.
- Enhanced test descriptions for clarity and improved reliability by using semantic queries for status updates.
- Adjusted utility functions to support the new testing approach, ensuring accurate representation of connection states.
- Added .yarn/ to .gitignore to prevent tracking of Yarn-related files.
- Removed .yarn/install-state.gz from .gitignore as it is no longer needed.
- Removed rimraf entries from resolutions and overrides in package.json.
- Updated rimraf version in yarn.lock to 2.7.1 and adjusted its dependencies accordingly.
- Deleted the .yarn/install-state.gz file as it is no longer needed, streamlining the project structure.
…alendar

- Updated tests to use getByRole for improved accessibility and clarity in verifying Google Calendar connection statuses.
- Adjusted status messages to provide clearer context for users, ensuring accurate representation of connection states in the tests.
- Replaced `yarn install --frozen-lockfile --network-timeout 300000` with `yarn install --immutable` across documentation and workflow files for consistency.
- Added `httpTimeout` setting in `.yarnrc.yml` to manage slow networks and large installs, enhancing installation reliability.
- Changed the build command in build.ts to use `yarn webpack` instead of `webpack`, ensuring consistency with Yarn usage across the project.
@tyler-dane tyler-dane merged commit 6dabe7f into main Mar 21, 2026
9 checks passed
@tyler-dane tyler-dane deleted the dependencies/fix-warnings branch March 21, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant