refactor: add frontend coding convention for component structure and update Google connection types#1596
Merged
tyler-dane merged 2 commits intomainfrom Apr 3, 2026
Conversation
…te Google connection types - Introduced a new guideline in the coding conventions document specifying that each React component should be placed in its own file to enhance modularity. - Removed the optional "tone" property from the Google connection sidebar status type for cleaner type definitions. - Refactored the Google connection utility to utilize a new `buildRepairDialog` function, improving the organization of repair dialog logic. - Created a new `MonthNavButton` component to encapsulate month navigation button functionality in the DatePicker, promoting reusability and clarity.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…vButton component - Refactored the DatePicker component to destructure props for improved readability and maintainability. - Removed the onInputBlur prop to simplify the interface. - Integrated the new MonthNavButton component for month navigation, enhancing modularity and reusability. - Updated the renderCustomHeader method to utilize the new MonthNavButton for previous and next month navigation, improving code clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildRepairDialogfunction, improving the organization of repair dialog logic.MonthNavButtoncomponent to encapsulate month navigation button functionality in the DatePicker, promoting reusability and clarity.Note
Low Risk
Low risk refactor and documentation update; main impact is TypeScript type tightening and small DatePicker prop/ref handling changes that could affect calendar navigation or callbacks if miswired.
Overview
Updates developer docs with a new frontend convention to keep one React component per file.
Simplifies Google Calendar connect UI configuration by removing the
sidebarStatus.tonefield and deduplicating the repair dialog content via a sharedbuildRepairDialoghelper.Refactors
DatePickerto extract month navigation buttons into a newMonthNavButtoncomponent and tweaks prop handling (defaultportalId, callback forwarding, and ref assignment) while preserving the existing UI behavior.Written by Cursor Bugbot for commit f0906a4. This will update automatically on new commits. Configure here.