feat: cleanup hotkeys#1626
Merged
tyler-dane merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Hotkey handling is refactored from ad-hoc DOM
keydownlisteners/handlers touseAppHotkey, which can subtly change shortcut scoping and event behavior (focus/typing fields, preventDefault/propagation). Impacts core keyboard flows in the calendar sidebar and grid scrolling.Overview
Refactors calendar keyboard shortcuts to use the shared
useAppHotkeyhook instead of component-levelonKeyDown/windowlisteners.In
SomedayEventContainer, Enter-to-edit and Meta+Ctrl+ArrowUp/Down migrations are now registered as focus-gated hotkeys, andSomedayEventno longer accepts/passes anonKeyDownprop. InuseScroll, the "c" shortcut to scroll to “now” is moved touseAppHotkey, and related tests are updated to usefireEvent.focusfor focus setup.Reviewed by Cursor Bugbot for commit 230ed4f. Bugbot is set up for automated code reviews on this repo. Configure here.