fix(backend): incomplete string escaping or encoding#1666
Merged
tyler-dane merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
…ing or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2 tasks
tyler-dane
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SwitchbackTech/compass/security/code-scanning/44
Use URL decoding for the captured path segment instead of manually replacing a single token.
Best fix in this file (
packages/backend/src/common/services/gcal/gcal.utils.ts), aroundgetEmailFromUrllines 38–45:emailMatch[1].replace("%40", "@")withdecodeURIComponent(emailMatch[1]).try/catchso malformed percent-encoding doesn’t throw and break flow; returnnullon decode failure (same fallback style as current function).This preserves existing behavior for valid inputs and improves correctness for all encoded characters (including multiple
%40occurrences).Suggested fixes powered by Copilot Autofix. Review carefully before merging.