Hide recurrence controls without backend support#1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The main purpose of this PR is to keep recurring event controls out of local/frontend-only mode. Recurring events depend on the backend-backed event model and MongoDB; IndexedDB local storage is not meant to fully handle that behavior. When Compass is running with only the web app, or when a self-hosted/custom setup has the web app up but the backend or MongoDB is unavailable, the UI should not invite users into recurrence flows that cannot be supported safely.
While tracing that issue, we found the broader cause: the frontend still tried to use backend-backed paths in several places even when the backend was not reachable. That meant users could see raw
ApiError: Request failedmessages, event changes could keep trying the API instead of saving locally, and sign out could stall while the browser repeatedly attempted backend session requests.This PR makes the web app degrade cleanly when the backend is unavailable. It does not try to turn signed-in cloud usage into a full offline-sync mode.
What changed
Validation
bun run test:webbunx biome checkon the touched web filesThe focused Biome check passed with existing console warnings in the web build/dev scripts.