Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a dedicated
type-checkjob to the existing unit-test GitHub Actions workflow, sobun run type-checkis enforced by CI instead of only being a local/manual check.The root type-check was not clean on
origin/main, so this PR also tightens the root TypeScript config and fixes the few source issues that blocked it from becoming a reliable CI gate.After opening the PR, CI also exposed an e2e flake in the OAuth sidebar connection-status test: Playwright hit a native JavaScript dialog while the page/session was closing and reported
Page.handleJavaScriptDialog. This PR now makes the OAuth e2e harness neutralize native dialogs during those mocked OAuth tests, and enables CI-only Playwright retries so transient browser/session flakes get another attempt without changing local fail-fast behavior.What changed
type-checkjob to.github/workflows/test-unit.yml.bun install --frozen-lockfilebun run type-checkimport.metausage.alert/confirm/promptdialogs.Why
The TypeScript upgrade showed that CI did not currently prove the repo type-checks. Package tests are useful, but they do not catch the same class of compiler/configuration issues. This makes type-checking a first-class CI signal going forward.
The OAuth e2e update keeps mocked OAuth tests focused on app state instead of failing on browser dialog plumbing during CI teardown.
Validation
bun run type-checkpassed.bun run test:scriptspassed.bun run test:backendpassed when run by itself.bun run lintexited successfully with the existing repo warning backlog.bun run format:checkcompleted without changes.git diff --checkpassed.bunx playwright test e2e/oauth --project=chromium-desktop --repeat-each=5passed: 70/70.CI=1 bun run test:e2epassed locally: 30 passed, 3 skipped.Note
I initially ran backend and scripts tests at the same time locally and backend hit the known local Mongo test harness collision around
globalConfig.json. Rerunning backend by itself passed, and CI runs jobs in isolated runners.