chore(web): clean up low-risk lint warnings#1680
Merged
Conversation
Uarmagan
added a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the lowest-risk lint noise in mechanical passes. It removes unused imports, lets Biome reorder class names, adds explicit
type="button"attributes to action buttons, and simplifies literal string-key property access where Biome can prove dot access is equivalent.The intent is to reduce warning and info noise without touching the more judgment-heavy categories like React hook dependencies or non-null assertions.
What changed
Validation
bunx biome check . --only=lint/correctness/noUnusedImports --only=lint/nursery/useSortedClasses --only=lint/a11y/useButtonType --max-diagnostics=nonebunx biome check . --only=lint/complexity/useLiteralKeys --max-diagnostics=nonebun run lintbun run test:corebun run test:scriptsbun run test:backendbun test --cwd packages/web src/common/hooks/useBufferedVisibility.test.ts src/common/hooks/useEventDNDActions.test.ts src/components/DND/DNDContext.test.tsx src/components/Tooltip/TooltipWrapper.test.tsx src/ducks/events/sagas/someday.sagas.test.ts src/views/Day/components/ShortcutsSidebar/ShortcutsSidebar.test.tsxbun test --cwd packages/web src/auth/compass/session/session.util.test.ts src/common/parsers/view.parser.test.tsNote: I also tried the full
bun run test:websuite before the literal-key follow-up. It progressed through many passing files, then Bun itself crashed while startingsrc/common/utils/app-init.util.test.ts. The focused touched-file test runs above completed successfully.