fix(web): align command palette navigation#1821
Merged
Merged
Conversation
…avigation-1808 # Conflicts: # packages/web/src/views/Day/components/DayCmdPalette.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the command palette navigation sections so Week, Day, and Now present the same kind of view-switching actions.
Before this change, each view built its own command palette navigation list. That made the palette feel different depending on where you opened it: Week did not have a Navigation section, Day mixed create/edit actions into Navigation, and Now was missing Today while also mixing reminder editing into Navigation.
This PR:
tshortcut for “Go to Today,” matching the command palette label and shortcut helpCloses #1808
Validation
tshortcut goes to todaybun test src/common/constants/navigation.cmd.constants.test.ts src/views/Now/shortcuts/useNowShortcuts.test.tsx src/common/utils/shortcut/data/shortcuts.data.test.tsfrompackages/webbun type-checkbun lintgit diff --checkNote:
bun test:webcurrently hits a repeatable Bun segmentation fault while startingsrc/common/hooks/useLogoutCmdItems.test.ts. That test passes when run directly, and the full run progressed cleanly otherwise, so I treated it as a Bun/runtime issue rather than a regression from this PR.