Skip to content

fix(web): align command palette navigation#1821

Merged
Uarmagan merged 2 commits into
mainfrom
fix/command-palette-navigation-1808
May 30, 2026
Merged

fix(web): align command palette navigation#1821
Uarmagan merged 2 commits into
mainfrom
fix/command-palette-navigation-1808

Conversation

@Uarmagan
Copy link
Copy Markdown
Contributor

Summary

Fixes the command palette navigation sections so Week, Day, and Now present the same kind of view-switching actions.

Before this change, each view built its own command palette navigation list. That made the palette feel different depending on where you opened it: Week did not have a Navigation section, Day mixed create/edit actions into Navigation, and Now was missing Today while also mixing reminder editing into Navigation.

This PR:

  • adds one shared navigation item builder for the view-switching commands
  • gives Week, Day, and Now consistent Navigation sections
  • keeps create/edit/reminder actions under Common Tasks instead of Navigation
  • adds a real Now t shortcut for “Go to Today,” matching the command palette label and shortcut help

Closes #1808

Validation

  • Reproduced the original inconsistency in Browser before changing code.
  • Re-tested in Browser after the fix:
    • Week palette shows Now, Day, and Today under Navigation
    • Day palette shows Now, Week, and Today under Navigation
    • Now palette shows Day, Week, and Today under Navigation
    • Week → Now works from the palette
    • Now → Today works from the palette
    • Now t shortcut goes to today
    • Day → Week works from the palette
  • bun test src/common/constants/navigation.cmd.constants.test.ts src/views/Now/shortcuts/useNowShortcuts.test.tsx src/common/utils/shortcut/data/shortcuts.data.test.ts from packages/web
  • bun type-check
  • bun lint
  • git diff --check

Note: bun test:web currently hits a repeatable Bun segmentation fault while starting src/common/hooks/useLogoutCmdItems.test.ts. That test passes when run directly, and the full run progressed cleanly otherwise, so I treated it as a Bun/runtime issue rather than a regression from this PR.

@Uarmagan Uarmagan marked this pull request as ready for review May 28, 2026 16:01
…avigation-1808

# Conflicts:
#	packages/web/src/views/Day/components/DayCmdPalette.tsx
@Uarmagan Uarmagan merged commit 348c576 into main May 30, 2026
9 checks passed
@Uarmagan Uarmagan deleted the fix/command-palette-navigation-1808 branch May 30, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cmd palette navigation items are not consistent across views

1 participant